Skip to content

Fix contrast property read #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025
Merged

Conversation

relic-se
Copy link
Contributor

The original property getter for contrast used a copy of the brightness property getter which resulted in the contrast property reporting the same as the brightness property and not the current camera contrast. This update rewrites the getter to fix this issue.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @relic-se!

This looks good to me, I tested the change successfully with a Pico2 and cowbell camera and confirmed contrast is now reporting the value it was set to properly.

@FoamyGuy FoamyGuy merged commit 33460da into adafruit:main May 21, 2025
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 22, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_OV5640 to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#39 from relic-se/contrast-getter
  > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#38 from relic-se/contrast-range-docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_OV to 1.1.4 from 1.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_OV#23 from adafruit/use_ruff

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT31D to 2.3.27 from 2.3.26:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHT31D#38 from adafruit/use_ruff

Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA8418 to 1.0.17 from 1.0.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_TCA8418#17 from FoamyGuy/displayio_api_update

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Beacon to 1.0.9 from 1.0.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Beacon#5 from adafruit/use_ruff

Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.4.2 from 1.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_datetime#33 from jepler/datetime-replace-typing

Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI_Parser to 1.2.0 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI_Parser#3 from adafruit/polyphony

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 4.0.4 from 4.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#72 from adafruit/use_ruff

Updating https://github.com/adafruit/Adafruit_CircuitPython_PYOA to 2.6.4 from 2.6.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#42 from adafruit/use_ruff

Updating https://github.com/adafruit/Adafruit_CircuitPython_Radial_Controller to 1.0.15 from 1.0.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_Radial_Controller#4 from adafruit/use_ruff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants